search

mmiron-HC / WST-RSAMS

0 stars 0 forks source link

Dashboard: Revisions tab - Two compare buttons appear on the page but only one is included in the instruction #115

Open XiuJuanXia opened 3 years ago

XiuJuanXia commented 3 years ago

URL: https://hcdev.openplus.ca/en/node/60168/revisions User Agent: Chrome Language: English

Issue Description: There are two "Compare selected revisions" buttons on the page, but the instruction text only contains one that is located after the table "To compare two revisions, use the radio buttons from column A and B and press the compare button at the bottom of the table." image

Steps to reproduce:

  1. Log into the Dashboard
  2. Action on the "Build"
  3. Select "Revisions" tab
  4. Visual check

Expected results: The two "Compare selected revisions" buttons should be mentioned in the instruction text or only keep one button.

echouin commented 3 years ago

@XiuJuanXia From OP: this is related to the Diff module. There isn't much we can do about it unless you want us to rewrite the module.

davidgotlieb commented 2 years ago

Modified the instructions

XiuJuanXia commented 2 years ago

There is a minor issue in the modified instructions:

Use the radio buttons in the table below to select two revisions to compare. Then click the "Compare selected revisions" button to generate the comparison.

The Word "click" should be avoided. Perhaps use word "activate" for buttons.

echouin commented 2 years ago

@XiuJuanXia Can you give me the link to where you see this?

XiuJuanXia commented 2 years ago

@echouin, here is the link: https://rsams.dev.cloud.openplus.ca/en/node/64010/revisions

echouin commented 2 years ago

@XiuJuanXia OpenPlus has reported the issue to Drupal: https://www.drupal.org/project/diff/issues/3269171. Updated the entry.