search

mmiron-HC / WST-RSAMS

0 stars 0 forks source link

Decorative image does not require the title attribute #134

Open ndolter opened 2 years ago

ndolter commented 2 years ago

URL: https://recalls-rappels.canada.ca/fr/avis-rappel/rappel-certains-produits-vegetaliens-et-vegetariens-marque-happy-veggie-world-hearts User Agent: Chrome v98 Language: English & French

Issue Description: The fork and knife image are decorative and do not require a title attribute. The current title attribute does not provide any meaning to screen reader users. It adds no value considering the alt attribute is empty.

Steps to reproduce:

  1. Navigate to the url above. Or search on: Certain Happy Veggie World, Hearts Choices, and Vegefarm brand vegan and vegetarian products recalled due to undeclared egg
  2. Navigate to the Related AWRs section
  3. View the code or hover over the image with the mouse

Expected Result: To avoid any kind of confusion the title attribute should be removed from all decorative images.

image

echouin commented 2 years ago

@ndolter this is part of older migrated content that was exported as flat HTML. We made a decision at the outset of the project to import 19,000 older records which would inevitably have issues. In order to fix all of them, each of the 19,000 records would need to be re-entered into the new system by individual(s) which is simply not feasible at this time.

mmiron-HC commented 2 years ago

@echouin I understand what you are saying, however from our end, these are no resolved. We need these to stay open. We cannot close it until it is fixed. A suggestion would be to create another label such as "legacy" or something meaningful to differentiate these types of issues from the rest. I will let you decide.

echouin commented 2 years ago

Hi @mmiron-HC it will not be fixed for the 19,000 records. Yes, I concur with "Legacy". @davidgotlieb does that work for you?

davidgotlieb commented 2 years ago

Sure, Legacy works

mmiron-HC commented 2 years ago

@davidgotlieb @echouin tagged this one with legacy. Please tag the other ones that you feel fit this criteria.

echouin commented 2 years ago

@mmiron-HC could the Milestone be "legacy: not fixed"? I typically sort that way when auditing.

mmiron-HC commented 2 years ago

@echouin yes it can. I was too fast on the other one. Legacy w status of Not Fixed works.

mmiron-HC commented 1 month ago

@40999221 @zimw7 @YuxuanXie01 please retest and provide comment if fixed/fails, Thanks.

YuxuanXie01 commented 1 month ago

Retested, not fixed. Decorative images still have title attribute. image

zimw7 commented 1 month ago

Issue still exists. The title attribute has not been removed from the decorative images Snap6

40999221 commented 1 month ago

Retested and issue still exist. Title attribute is still there on decorative images.

image

mmiron-HC commented 1 month ago

@zimw7 can you please bring this one over to Jira. When you have, please add a label of moved_to_Jira to this ticket.