mmiron-HC / WST-RSAMS

0 stars 0 forks source link

Build: "Press ALT 0 for help" only available for screen reader users #144

Open XiuJuanXia opened 2 years ago

XiuJuanXia commented 2 years ago

URL: https://rsams.dev.cloud.openplus.ca/en/node/64020/build User Agent: Chrome (v99), Firefox (v98), JAWS 2020, NVDA 2021.1 Language: Both

Issue Description: When tabbing to "Rich Text Editor, Comment field", an invisible instruction text "Press ALT 0 for help" is only available for screen reader users. Keyboard users are not aware of the shortcut and not able to open up the "Accessibility Instructions" modal. image

Steps to reproduce:

  1. Login as an admin: https://rsams.dev.cloud.openplus.ca/en/user/login
  2. Activate "Build"
  3. Turn on screen reader
  4. Navigate to "Internal notes" section
  5. Tabbing to "Rich Text Editor, Comment field", an invisible instruction text "Press ALT 0 for help" is only available for screen reader users.

Expected results: The shortcut ALT 0 to open the "Accessibility instructions" MUST be available to all users.

davidgotlieb commented 1 year ago

This tag has been hidden using the { display: none;} tag, which is the recommended approach for hiding a tag from all users (including screen readers)

According to this article there are some reports of older screen readers not recognizing this tag, but seems like it's still be recommended approach.

https://www.nomensa.com/blog/how-improve-web-accessibility-hiding-elements

The tag itself is autogenerated by the CKeditor , which is built into Drupal and not something we can change, so hiding it is the best bet.

Is this happening on all readers?

mmiron-HC commented 1 year ago

@davidgotlieb without access we can't comment further. Yes technically if it has display:none, then it shouldn't be visible to any user but I can't validate at the moment.

davidgotlieb commented 1 year ago

OP just tested with their screen reader and it didn't get read out. I'll mark as resolved for now. If we do another round of confirmatory testing we can dig deeper about which screen reader it's happening on etc.