mmistakes / jekyll-theme-hpstr

A Jekyll theme with some tumble-log tendencies.
https://mmistakes.github.io/jekyll-theme-hpstr/
MIT License
980 stars 1.44k forks source link

Include static navbar? #20

Closed maxheld83 closed 10 years ago

maxheld83 commented 10 years ago

I love this theme, and it's minimalist design (as your other jekyll themes) -- I just wish it had an (optional?) static navbar. I like the foldaway navbar and the flashy animation, I just worry that some of my not-so-tech-savvy visitors might be confused about the navigation.

Does that make sense?

Is that something you would consider design-wise or does that not sit with your idea of hpstr?

mmistakes commented 10 years ago

@maxheld83 I wouldn't say never, but the design is pretty much the way I want it for this theme. One of my other themes with static headers are always an option.

mmistakes commented 10 years ago

@maxheld83 With some minor changes to Javascript and CSS the menu can be forced to stay open. I don't remember where I explained how to do it, but it's come up a few times before. If you inspect the menu in something like Chrome dev tools you'll see a dl-menuopen class is added to it on click.

If you want it to stay open and make it more obvious to your visitors you just need to modify the menu script and permanently apply that menu open class.

Next to me making everything about the theme an optional toggle I think this solution works pretty well.

maxheld83 commented 10 years ago

@mmistakes yes absolutely, that ought to do the trick! Thanks a bunch!