mmistakes / minimal-mistakes

:triangular_ruler: Jekyll theme for building a personal site, blog, project documentation, or portfolio.
https://mmistakes.github.io/minimal-mistakes/
MIT License
12.24k stars 25.35k forks source link

Translation not working anymore #1557

Closed lsolesen closed 6 years ago

lsolesen commented 6 years ago

Environment informations


Expected behavior

UI strings are translated to Danish - but they are not: see http://historie.vih.dk/

Steps to reproduce the behavior

The UI strings are not translated anymore. I am not sure whether it has worked for me since switching to remote_theme: "mmistakes/minimal-mistakes@4.9.1". See repository: https://github.com/vih/historie

mmistakes commented 6 years ago

You're missing the ui-text.yml data file. Remote themes don't pull in _data files from the bundled files, so you have to manually copy it over to your repo.

lsolesen commented 6 years ago

Do. Sorry about that. I thought it went from the remote theme.

mmistakes commented 6 years ago

It pulls when you use it as a theme gem since that utilizes a 3rd party plugin to copy the theme's _data files. But sadly that plugin isn't supported on GitHub Pages yet so you have to go through the extra step of copying the file yourself.