search

mmistakes / minimal-mistakes

:triangular_ruler: Jekyll theme for building a personal site, blog, project documentation, or portfolio.
https://mmistakes.github.io/minimal-mistakes/
MIT License
12.44k stars 25.63k forks source link

Immersive navbar / masthead? #2293

Closed iBug closed 4 years ago

iBug commented 5 years ago

Summary

Allow immersive masthead when a header image is present.

Motivation

Immersive masthead would beautiful for a landing page (MM squash layout). Example: https://volny.github.io/creative-theme-jekyll/

Drawbacks

No.

iBug commented 5 years ago

My badly-coded working demo: https://ibugone.com/

I only enabled this "immersive" navbar for larger screens (1024px and up) because I actually applied the same background to both navbar and header area, with settings url() 0 / cover fixed, so the two independent background images "looks smoothly joint". I haven't found a way to replicate this without background-attachment: fixed so I didn't implement this for smaller screens (no fixed for 1023px and smaller width).

Perhaps a change in HTML structure would help a lot, but it could be potentially destructive so I'm not expecting it.

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity.

If this is a bug and you can still reproduce this error on the master branch, please reply with any additional information you have about it in order to keep the issue open.

If this is a feature request, please consider whether it can be accomplished in another way. If it cannot, please elaborate on why it is core to this project and why you feel more than 80% of users would find this beneficial.

This issue will automatically be closed in 7 days if no further activity occurs. Thank you for all your contributions.