mmistakes / minimal-mistakes

:triangular_ruler: Jekyll theme for building a personal site, blog, project documentation, or portfolio.
https://mmistakes.github.io/minimal-mistakes/
MIT License
12.4k stars 25.56k forks source link

Deprecation warnings relative to use of / outside of calc, will be removed in Dart Sass 2.0.0 #4303

Open chmorgan opened 1 year ago

chmorgan commented 1 year ago

What happened?

Expected behavior

There are a number of deprecation warnings during the build:

  minimal-mistakes.scss 18:9                                                                                             @import
    /Users/cmorgan/projects/cmorgan-org/blog/assets/css/main.scss 4:9                                                      root stylesheet
Deprecation Warning: Using / for division outside of calc() is deprecated and will be removed in Dart Sass 2.0.0.

Recommendation: math.div(5px, 2) or calc(5px / 2)

More info and automated migrator: https://sass-lang.com/d/slash-div

   ╷
28 │     margin-bottom: (5px / 2);
   │                     ^^^^^^^
   ╵
    ../../../../minimal-mistakes-jekyll-4.24.0/_sass/minimal-mistakes/_forms.scss 28:21  @import
    minimal-mistakes.scss 20:9                                                           @import
    /Users/cmorgan/projects/cmorgan-org/blog/assets/css/main.scss 4:9                    root stylesheet
Deprecation Warning: Using / for division outside of calc() is deprecated and will be removed in Dart Sass 2.0.0.

Recommendation: math.div(($red * 299) + ($green * 587) + ($blue * 114), 1000) or calc((($red * 299) + ($green * 587) + ($blue * 114)) / 1000)

More info and automated migrator: https://sass-lang.com/d/slash-div

   ╷
68 │   $yiq: (($red*299)+($green*587)+($blue*114))/1000;
   │         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   ╵
    ../../../../minimal-mistakes-jekyll-4.24.0/_sass/minimal-mistakes/_mixins.scss 68:9   yiq-is-light()
    ../../../../minimal-mistakes-jekyll-4.24.0/_sass/minimal-mistakes/_mixins.scss 81:14  yiq-contrast-color()
    ../../../../minimal-mistakes-jekyll-4.24.0/_sass/minimal-mistakes/_mixins.scss 91:10  yiq-contrasted()
    ../../../../minimal-mistakes-jekyll-4.24.0/_sass/minimal-mistakes/_buttons.scss 46:7  @import
    minimal-mistakes.scss 25:9                                                            @import
    /Users/cmorgan/projects/cmorgan-org/blog/assets/css/main.scss 4:9                     root stylesheet
Deprecation Warning: Using / for division outside of calc() is deprecated and will be removed in Dart Sass 2.0.0.

Recommendation: math.div($span-width, $container) or calc($span-width / $container)

More info and automated migrator: https://sass-lang.com/d/slash-div

   ╷
93 │     @return percentage($span-width / $container);
   │                        ^^^^^^^^^^^^^^^^^^^^^^^^
   ╵

Steps to reproduce the behavior

Installed the theme on a clean jekyll project, build with 'bundle exec jekyll build'

Full log output not included as it doesn't appear necessary to observe the issue.

Other

No response

andr11b commented 1 year ago

Already discussed here #4054