search

mmisw / orr-portal

ORR Frontend component
Apache License 2.0
8 stars 5 forks source link

Input elements should have autocomplete attributes #122

Closed carueda closed 5 years ago

carueda commented 6 years ago

Noted by Chrome dev console while logging in:

Input elements should have autocomplete attributes (suggested: "current-password"): (More info: https://goo.gl/9p2vKq)

image

lbassuncao commented 6 years ago

This is extremly annooying! I don't want autocomplete on my forms. But since Chrome throw these annoying warning messages, I added autocomplete to all inputs with autocomple=Off, but it still complaining!

IamAlta commented 6 years ago

Ignore it. Those are only warnings. It's dumb that google does that since all the security and privacy issues these days.

jmkh commented 5 years ago

<input type="password" id="password" name="password" class="login_input login_input_password" maxlength="16" autocomplete="current-password" required minlength="6" onkeyup="value=value.replace(/[^\w.\/]/ig,'')" title="请输入登录密码" placeholder="请输入登录密码">

lewismc commented 5 years ago

@carueda is this issue valid or do we close it?

carueda commented 5 years ago

I think I entered this thinking that it would be convenient (at least for me) to have this kind of autocompletion in place. But it does look like it might not be generally acceptable. Let's close it.

shahrukhaziz commented 8 months ago

Ignore it. Those are only warnings, it will not affect your code, but I think it would be great if you add input autocomplete it will help end user.