mmisw / orr-portal

ORR Frontend component
Apache License 2.0
8 stars 5 forks source link

`gulp install` not fully completing #165

Closed carueda closed 4 years ago

carueda commented 4 years ago

For some reason, gulp install is not fully completing so the destination directory doesn't get populated.

Reproducing:

$ rm -rf DEST && mkdir -p DEST

$ gulp install --base=/ont/ --dest=DEST

[15:28:38] Building version 3.9.4
[15:28:38] Will insert <base href="/ont/">
[15:28:38] dest=DEST
[15:28:38] Install destination: DEST
[15:28:38] Using gulpfile ~/github/mmisw/orr-portal/gulpfile.js
[15:28:38] Starting 'install'...
...
[15:28:38] Finished 'app_min_css' after 3.47 ms
[15:28:38] Starting 'do_install'...
[15:28:38] Finished 'do_install' after 1.44 ms
[15:28:38] Finished 'install' after 49 ms

The last subtask called above, do_install, should have copied the artifacts to the destination but DEST/ remains empty.

Workaround: repeat the gulp command:

$ gulp install --base=/ont/ --dest=DEST
...
$ ls DEST
css           img           indexdev.html sparql
fonts         index.html    js            vendor

@lewismc want to take this one?

lewismc commented 4 years ago

@lewismc want to take this one?

Yes I will but not today. I am finished for the week :)

carueda commented 4 years ago

Me too, I was not planning at all spending the whole day on this stuff .. but I think I'm almost successful building the new 3.9.4 image (with that workaround).

carueda commented 4 years ago

This has been fixed as part of other recent adjustments in build files.

Right now the sequence runs smoothly:

➜  orr-portal git:(master) ✗ rm -rf DEST && mkdir -p DEST

➜  orr-portal git:(master) ✗ gulp install --base=/ont/ --dest=DEST
[19:12:37] Building version 3.9.7
[19:12:37] Will insert <base href="/ont/">
[19:12:37] dest=DEST
[19:12:37] Install destination: DEST
[19:12:37] Using gulpfile ~/github/mmisw/orr-portal/gulpfile.js
[19:12:37] Starting 'install'...
[19:12:37] Starting 'check_dest'...
[19:12:37] Finished 'check_dest' after 715 μs
[19:12:37] Starting 'localConfig'...
[19:12:37] Starting 'baseStuff'...
[19:12:37] app task: EXCLUDING local.config.js
[19:12:37] Finished 'localConfig' after 8.54 ms
[19:12:37] Finished 'baseStuff' after 10 ms
[19:12:37] Starting 'vendor'...
[19:12:37] Finished 'vendor' after 5.87 ms
[19:12:37] Starting 'do_package'...
[19:12:37] Finished 'do_package' after 4.07 ms
[19:12:37] Starting 'config'...
[19:12:37] config: EXCLUDING local.config.js
[19:12:37] Finished 'config' after 1.52 ms
[19:12:37] Starting 'img'...
[19:12:37] Finished 'img' after 1.23 ms
[19:12:37] Starting 'vendor_other_fontawesome'...
[19:12:37] Starting 'vendor_other_bootstrap'...
[19:12:37] Finished 'vendor_other_fontawesome' after 1.1 ms
[19:12:37] Finished 'vendor_other_bootstrap' after 2.12 ms
[19:12:37] Starting 'app_min_js'...
[19:12:37] Finished 'app_min_js' after 16 ms
[19:12:37] Starting 'app_min_css'...
[19:12:37] Finished 'app_min_css' after 2.35 ms
[19:12:37] Starting 'do_install'...
[19:12:37] Finished 'do_install' after 1.03 ms
[19:12:37] Finished 'install' after 50 ms

➜  orr-portal git:(master) ✗ ls DEST
config        img           js
css           index.html    sparql
fonts         indexdev.html vendor