mmisw / orr-portal

ORR Frontend component
Apache License 2.0
8 stars 5 forks source link

CSV import for vocabulary table #31

Closed carueda closed 8 years ago

carueda commented 8 years ago

New option in vocabulary drop-down menu:

orr-portal_31a

Dialog to enter/paste CSV contents:

orr-portal_31b

Using the Example button:

orr-portal_31c

Resulting table upon importing the CSV contents:

orr-portal_31d

As illustrated with the example, the following cases are considered for creation of the properties according to each header string in the CSV contents:

graybeal commented 8 years ago

This is all VERY cool!

Some questions/notes:

carueda commented 8 years ago

Thanks John.

The new vocabulary tool supports multiple classes of terms in the same ontology (each class of terms being a table of terms considered as instances of a particular given class).

In general, this drop-down menu still needs to be smarter so it shows what makes sense according to the current number of "vocabularies" (again, classes of terms) as well as position of the particular vocabulary where the drop-down is located

I know, the term "vocabulary" is overloaded here so it will likely cause confusion, any suggestions for an alternative name when referring to the mentioned particular class of terms?

The 4 entries to move vocabulary or insert vocabulary I think aren't using the best word, I can't understand what they are doing or why you'd want to do that.

The move ones should be hidden (or disabled) as there's only one vocabulary (class of terms) in this example.

Thanks for the wording suggestions!

graybeal commented 8 years ago

Oh, I see how it works.

I think that interface, while beautiful, may be 'in the way' of a number of scenarios:

It's attractive enough, and the lost functionality minor enough, I'll be OK with it either way. Just keep in mind that if people think of their vocabularies primarily as being parts of different classes, they are likely to create separate ontologies for each class. So when many sub-vocabularies are in one ontology, it is probably an indication that the ontology is the dominant organizational paradigm, and the hierarchy is less significant, at least for many users.

A class of terms could be a term list, term set, term group, or term collection; value set (term of art in these parts); sub-vocabulary; or substitute 'concept' for term ... that's all for now. Not sure which fits best. 'class of terms' isn't really right. If you really want to be generic, call it a 'concept collection', as all terms are concepts but not all concepts are terms. Presumably this would work if the sub-terms were actually sub-classes?

carueda commented 8 years ago

I don't quite follow all of what you are saying ... we can probably better talk about all of this later..

For now, I was mainly "motivated" by https://github.com/mmisw/mmiorr/issues/114

carueda commented 8 years ago

Just pushed a change to use "term set" instead of "vocabulary" when referring to a particular term table within the vocabulary ontology. This at least should help with the distinction.

image

graybeal commented 8 years ago

I think that’s perfect, go with it and let’s see how the fans respond!