search

mmitch / gbsplay

gameboy sound player
https://mmitch.github.io/gbsplay/
Other
98 stars 19 forks source link

Build status for FreeBSD not shown in README.me #113

Closed mmitch closed 4 months ago

mmitch commented 5 months ago

These are the build status labels from our README.md:

Linux Build status FreeBSD Build status macOS Build status Windows Build status

The links work - when you click on them you are taken to the build pipeline. But the image link for the FreeBSD pipeline shows no status - why is that?

The source code for the badges looks like this:

[![Linux Build status](https://github.com/mmitch/gbsplay/workflows/Linux%20Build/badge.svg?branch=master)](https://github.com/mmitch/gbsplay/actions?query=workflow%3A%22Linux+Build%22)
[![FreeBSD Build status](https://github.com/mmitch/gbsplay/workflows/FreeBSD%20Build/badge.svg?branch=master)](https://github.com/mmitch/gbsplay/actions?query=workflow%3A%22FreeBSD+Build%22)
[![macOS Build status](https://github.com/mmitch/gbsplay/workflows/macOS%20Build/badge.svg?branch=master)](https://github.com/mmitch/gbsplay/actions?query=workflow%3A%22macOS+Build%22)
[![Windows Build status](https://github.com/mmitch/gbsplay/workflows/Windows%20Build/badge.svg?branch=master)](https://github.com/mmitch/gbsplay/actions?query=workflow%3A%22Windows+Build%22)

Or broken down the links to the images/badges:

https://github.com/mmitch/gbsplay/workflows/Linux%20Build/badge.svg?branch=master
https://github.com/mmitch/gbsplay/workflows/FreeBSD%20Build/badge.svg?branch=master
https://github.com/mmitch/gbsplay/workflows/macOS%20Build/badge.svg?branch=master
https://github.com/mmitch/gbsplay/workflows/Windows%20Build/badge.svg?branch=master

and the links to the workflows:

https://github.com/mmitch/gbsplay/actions?query=workflow%3A%22Linux+Build%22
https://github.com/mmitch/gbsplay/actions?query=workflow%3A%22FreeBSD+Build%22
https://github.com/mmitch/gbsplay/actions?query=workflow%3A%22macOS+Build%22
https://github.com/mmitch/gbsplay/actions?query=workflow%3A%22Windows+Build%22

These are the names as declared in the build YAMLs:

$ grep ^name .github/workflows/build_*
.github/workflows/build_freebsd.yml:name: FreeBSD Build
.github/workflows/build_linux.yml:name: Linux Build
.github/workflows/build_macos.yml:name: macOS Build
.github/workflows/build_windows.yml:name: Windows Build

Where is the difference between the FreeBSD badge and the other badges? Why is there no status? I see no difference.

mmitch commented 5 months ago

I just got notified about an update to this issue: https://github.com/orgs/community/discussions/14980 Looks like I had already encountered the same problem in another project and forgot about it. Removing the branch name from the image URL does indeed seem to fix the problem.