mmitch / gbsplay

gameboy sound player
https://mmitch.github.io/gbsplay/
Other
98 stars 19 forks source link

fix unknown version numbers #119

Closed mmitch closed 4 months ago

mmitch commented 4 months ago

This fixes unknown version numbers from builds based on GitHub tarballs and .ZIPs by guesstimating a version number based on the current HISTORY file (latest release plus x).

The current master has this problem (this will be fixed once this pull request is merged):

$ cd /tmp
$ wget -q https://github.com/mmitch/gbsplay/archive/refs/heads/master.zip && unzip master.zip >/dev/null
$ cd gbsplay-master && make >/dev/null 2>&1 && ./gbsplay -V
/tmp/gbsplay-master
gbsplay unknown

A .tar.gz from a release shows the same problem:

$ cd /tmp
$ wget -q https://github.com/mmitch/gbsplay/archive/refs/tags/0.0.96.tar.gz && tar -xzf 0.0.96.tar.gz
$ cd gbsplay-0.0.96 && make >/dev/null 2>&1 && ./gbsplay -V
/tmp/gbsplay-0.0.96
gbsplay unknown

Whereas the branch of this pull request is already fixed and tells us we're exactly at or somewhat after version 0.0.96:

$ cd /tmp
$ wget -q https://github.com/mmitch/gbsplay/archive/refs/heads/version-number.zip && unzip version-number.zip >/dev/null
$ cd gbsplay-version-number && make >/dev/null 2>&1 && ./gbsplay -V
/tmp/gbsplay-version-number
gbsplay 0.0.96ish

This pull request also makes configure show the version number in fhe first line of its output.

This fixes #118.