search

mmitch / gbsplay

gameboy sound player
https://mmitch.github.io/gbsplay/
Other
100 stars 20 forks source link

clear mapped RAM on subsong change #125

Closed mmitch closed 7 months ago

mmitch commented 7 months ago

This should fix #124.

I know @mrehkopf has already fixed the bug locally, but there was no pull request yet and it's only 6 lines of code ;-) He did most of the debugging, that's not my achievement.

Please have a good look at my commit message and HISTORY entry, I'm not sure if they are comprehensible and if I have used the correct technical terms. I'm open for better wording :)

mrehkopf commented 7 months ago

"mapped external cartridge mapped" in the message for 2f6a3092d6ea4636f28b46fdae25920fe00e9dde should probably be "mapped external cartridge RAM" ;-)

mmitch commented 7 months ago

I have added both changes (went with the sizeof(m->ram) variant) and found another typo in the commit message (onto -> into). Because I had to edit the commit message anyway, I simply did a rebase :)