mmitch / gbsplay

gameboy sound player
https://mmitch.github.io/gbsplay/
Other
98 stars 20 forks source link

either use code coverage or don't :) #31

Closed mmitch closed 4 years ago

mmitch commented 4 years ago

The travis.yml file currently contains part of a code coverage tool at the end:

after_success:
  - bash <(curl -s https://codecov.io/bash)

This code snippet would upload the coverage results to codecov.io, but we don't create any coverage data during our test run. The build log looks like this in the final step:

$ bash <(curl -s https://codecov.io/bash)

  _____          _
 / ____|        | |
| |     ___   __| | ___  ___ _____   __
| |    / _ \ / _` |/ _ \/ __/ _ \ \ / /
| |___| (_) | (_| |  __/ (_| (_) \ V /
 \_____\___/ \__,_|\___|\___\___/ \_/
                              Bash-20200629-ffaf297

==> Travis CI detected.
    project root: .
    Yaml not found, that's ok! Learn more at http://docs.codecov.io/docs/codecov-yaml
==> Running gcov in . (disable via -X gcov)
==> Python coveragepy not found
==> Searching for coverage reports in:
    + .
--> No coverage report found.
    Please visit http://docs.codecov.io/docs/supported-languages

Done. Your build exited with 0.

We should either generate coverage data and see what else is missing for codecov.io upload
or remove the after_success block altogether.

(also: piping curl to bash - yuck ;-)

mmitch commented 4 years ago

Coverage of the the gcc build w/o shared library test run is available at https://codecov.io/gh/mmitch/gbsplay