mmitch / gbsplay

gameboy sound player
https://mmitch.github.io/gbsplay/
Other
98 stars 20 forks source link

Fix off-by-one error in gbhw_io_peek #34

Closed Sanqui closed 3 years ago

Sanqui commented 3 years ago

This bug made e.g. WAVE display when verbose incorrect, as the last byte of the waveform would always be given as FF.

codecov[bot] commented 3 years ago

Codecov Report

Merging #34 into master will not change coverage. The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #34   +/-   ##
=======================================
  Coverage   42.19%   42.19%           
=======================================
  Files          17       17           
  Lines        2614     2614           
=======================================
  Hits         1103     1103           
  Misses       1511     1511           
Impacted Files Coverage Δ
gbhw.c 73.54% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 29ca153...e9ef7a8. Read the comment docs.