search

mmitch / gbsplay

gameboy sound player
https://mmitch.github.io/gbsplay/
Other
98 stars 20 forks source link

add SDL2 plugout #38

Closed mmitch closed 3 years ago

mmitch commented 3 years ago

Looks good on Linux, tested locally. The build servers concur.

I did a short test with macOS on the build servers (using brew install sdl2), but the installation went to /usr/local/Cellar/sdl2/2.0.12_1 and configure did not find it. We can look into this later, currently SDL is disabled on the builds.

MINGW32 and MINGW64 builds currently break for unknown reasons. Can anybody check this locally and perhaps add a fix?

I used sdl, SDL and also SDL2 for constants, variables and texts. I think the given choice makes sense in the given context, but if anybody wants me to streamline this (eg. SDL2 everywhere), please tell.

codecov[bot] commented 3 years ago

Codecov Report

Merging #38 (931159f) into master (e137de0) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #38   +/-   ##
=======================================
  Coverage   42.14%   42.14%           
=======================================
  Files          19       19           
  Lines        2724     2724           
=======================================
  Hits         1148     1148           
  Misses       1576     1576
Impacted Files Coverage Δ
plugout.c 36.36% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e137de0...931159f. Read the comment docs.

mmitch commented 3 years ago

Tested on Linux and MINGW. Build pipeline confirms compilation on Linux, macOS, and MINGW (no MSYS2 because there is no SDL2 package).

mmitch commented 3 years ago

I think that's all and we can merge. Any objections?