search

mmitch / gbsplay

gameboy sound player
https://mmitch.github.io/gbsplay/
Other
98 stars 20 forks source link

refactor metadata access in libgbs.h #56

Closed mmitch closed 3 years ago

mmitch commented 3 years ago

plus some refactoring in xgbsplay

I have one question, so I did not commit directly to master:

To decouple the internal metadata in gbs.c from the external metadata in libgbs.h, the three fields title/author/copyright get copied around in gbs_get_metadata() (or at least their pointers get copied around): https://github.com/mmitch/gbsplay/blob/7727a30a49ffe614e3441e2224d0975eff230b7f/gbs.c#L107-L113

Is this good? Or should we just use struct gbs->metadata->... internally and remove struct gbs->title, struct gbs->author and struct gbs->copyright altogether?

codecov[bot] commented 3 years ago

Codecov Report

Merging #56 (533fddf) into master (fe1b9d1) will increase coverage by 0.01%. The diff coverage is 0.00%.

Impacted Files Coverage Δ
gbs.c 29.92% <0.00%> (+0.05%) :arrow_up:
player.c 40.56% <0.00%> (ø)