search

mmitch / gbsplay

gameboy sound player
https://mmitch.github.io/gbsplay/
Other
98 stars 20 forks source link

replace 'echo -n' by 'printf' #65

Closed mmitch closed 3 years ago

mmitch commented 3 years ago

'echo -n' is not available everywhere, while 'printf' without a linebreak does the same and is defined by POSIX see https://pubs.opengroup.org/onlinepubs/9699919799/utilities/echo.html#tag_20_37_16 https://pubs.opengroup.org/onlinepubs/9699919799/utilities/printf.html#tag_20_94_18

Do we want this? It makes the code a little bit more complicated, but only in scripts used for the build pipelines. As the build pipelines all work with 'echo -n', is this even needed?

I'm happy to retract this pull request, I currently can't make up my mind. Need a second opinion ;-)

codecov[bot] commented 3 years ago

Codecov Report

Merging #65 (402034f) into master (0de54c1) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #65   +/-   ##
=======================================
  Coverage   46.50%   46.50%           
=======================================
  Files          20       20           
  Lines        2903     2903           
=======================================
  Hits         1350     1350           
  Misses       1553     1553

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0de54c1...402034f. Read the comment docs.