search

mmitch / gbsplay

gameboy sound player
https://mmitch.github.io/gbsplay/
Other
98 stars 20 forks source link

Typo in plugout_midi ? #98

Closed orzel closed 1 year ago

orzel commented 1 year ago

Here

In plugout_midi.c the code looks like 

            for (chan = 0; chan < 4; chan++) {
                div[chan] = 0;
                volume[chan] = 0;
                running[chan] = 0;
                master[chan] = 1;
                midi_note_off(cycles, 2);
            }

although, to my understanding, it should rather be midi_note_off(cycles, chan);

Isn't it ?

mmitch commented 1 year ago

It certainly looks that way, thanks for spotting it!

mmitch commented 1 year ago

Our tests did not detect any changes in the MIDI plugout checks, so our example file does not seem to the NR52 "sound off" command. I don't know of any certain GBS that does this, so I just ran some general listening tests with the MIDI plugout and declare it in working condition ;-)

Merged to master, thanks again!

orzel commented 1 year ago

thx for fixing it :)