search

mmkal / handy-redis

A wrapper around node_redis with Promise and TypeScript support.
Apache License 2.0
172 stars 10 forks source link

Fixes "Cannot redeclare block-scoped variable 'addCommand'" #311

Closed CanTheAlmighty closed 3 years ago

CanTheAlmighty commented 3 years ago

The method was changed on @types/redis and as such, it clashed with the definition inside the project.

Definitely typed now offers this method: https://github.com/DefinitelyTyped/DefinitelyTyped/commit/fa3bd98507d1c677b63f4effce230b153fff4403

The update does the following

  1. Removes the clashing declaration
  2. Updates package.json and yarn.lock to the newest @types/redis to guarantee the new method is used.
  3. Auto-generated files?
mmkal commented 3 years ago

Looks like the error is because of the lockfile being out of date. Feel free to push a fix, otherwise I will sort out over the weekend.

codecov-commenter commented 3 years ago

Codecov Report

Merging #311 (243c8f0) into master (e7f78d8) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #311   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           12        12           
  Lines          484       484           
  Branches        91       105   +14     
=========================================
  Hits           484       484
Impacted Files Coverage Δ
src/node_redis/index.ts 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e7f78d8...243c8f0. Read the comment docs.

mmkal commented 3 years ago

Thanks @CanTheAlmighty!

CanTheAlmighty commented 3 years ago

Thanks @CanTheAlmighty!

Thanks for taking care of your lib so quickly