search

mml-book / mml-book.github.io

Companion webpage to the book "Mathematics For Machine Learning"
13.04k stars 2.41k forks source link

Add remark about Givens rotation to chapter "Rotations is n Dimensions" #654

Open bartkowiaktomasz opened 3 years ago

bartkowiaktomasz commented 3 years ago

Is your feature request related to a problem? Please describe. The formula (3.78) (Chapter 3.9.2 Rotations in $R^3$, p.93) - Rotation about the $e_2$-axis - is inconsistent with the formula (3.80) (Chapter 39.3 Givens rotation, p.94). This might be confusing to a reader (i.e. a general case is inconsistent with a particular case).

Describe the solution you'd like Add a remark that the rotation (3.78) is not a Givens rotation, because Givens rotation does not necessarily respect the "right-hand rule".

Describe alternatives you've considered N/A

Additional context N/A

michaelmyc commented 1 year ago

Adding this Wikipedia link for reference: https://en.wikipedia.org/wiki/Givens_rotation#cite_note-3