mml-io / mml

Metaverse Markup Language
https://mml.io
MIT License
120 stars 13 forks source link

Fixed m-video enabled attribute reusability bug #153 #154

Closed MarcusLongmuir closed 6 months ago

MarcusLongmuir commented 6 months ago

Fixes #153

This PR fixes an issue where if the enabled attribute of an m-video was set to false, setting it back to true would not bring the video back as the material would not be assigned back to the mesh.

The fix also fixes a related issue where setting enabled="false" would not actually stop the video from playing sound.

The change to fix both issues is to actually disable the current content completely and then re-enable it when enabled="false" is removed.


What kind of changes does your PR introduce? (check at least one)

Does your PR introduce a breaking change? (check one)

Does your PR fulfill the following requirements?