This PR implements a cast-shadow boolean attribute to the <m-light> tag to allow the user to enable (default) or disable shadow casting for the m-lights in an MML document.
MML uses ThreeJS on mml-web, and ThreeJS uses shadow maps by default. That means having more than 15 lights casting shadows on a scene will likely exceed the number of texture units available for the WebGL context. Even when not exceeding the limit, a high number of shadow-casting lights with shadow maps impose a brutal performance impact (as every light casting shadows must draw every object in the scene from its own perspective to draw the shadows, and finally the renderer needs an extra draw call to blend all the shadow maps).
What kind of changes does your PR introduce? (check at least one)
[ ] Bugfix
[X] Feature
[ ] Refactor
[ ] Tests
[ ] Other, please describe:
Does your PR introduce a breaking change? (check one)
[ ] Yes
[X] No
If yes, please describe its impact and migration path for existing applications:
Does your PR fulfill the following requirements?
[X] All tests are passing
[ ] The title references the corresponding issue # (if relevant)
This PR implements a
cast-shadowboolean attribute to the<m-light>tag to allow the user to enable (default) or disable shadow casting for them-lightsin an MML document.MML uses ThreeJS on
mml-web, and ThreeJS uses shadow maps by default. That means having more than 15 lights casting shadows on a scene will likely exceed the number of texture units available for the WebGL context. Even when not exceeding the limit, a high number of shadow-casting lights with shadow maps impose a brutal performance impact (as every light casting shadows must draw every object in the scene from its own perspective to draw the shadows, and finally the renderer needs an extra draw call to blend all the shadow maps).What kind of changes does your PR introduce? (check at least one)
Does your PR introduce a breaking change? (check one)
If yes, please describe its impact and migration path for existing applications:
Does your PR fulfill the following requirements?