The removal of loading progress of static m-frames was being reported to the wrong LoadingProgressManager. It should have been being reported to the parent LoadingProgressManager, but was instead reported to its own. This meant that the parent LoadingProgressManager was retaining a reference to the m-frame element which was preventing it from being garbage collected.
There are also two minor drive-by fixes that were found during investigation that prevent holding references to previous instance data.
cc @tbergmueller
What kind of changes does your PR introduce? (check at least one)
[x] Bugfix
Does your PR introduce a breaking change? (check one)
[x] No
Does your PR fulfill the following requirements?
[ ] All tests are passing
[x] The title references the corresponding issue # (if relevant)
Fixes #178.
The removal of loading progress of static
m-frames was being reported to the wrongLoadingProgressManager. It should have been being reported to the parentLoadingProgressManager, but was instead reported to its own. This meant that the parentLoadingProgressManagerwas retaining a reference to them-frameelement which was preventing it from being garbage collected.There are also two minor drive-by fixes that were found during investigation that prevent holding references to previous instance data.
cc @tbergmueller
What kind of changes does your PR introduce? (check at least one)
Does your PR introduce a breaking change? (check one)
Does your PR fulfill the following requirements?