search

mmmries / nkeys

Elixir support for working with nkeys
2 stars 1 forks source link

Remove Bitwise warning on compilation #2

Closed sleipnir closed 1 year ago

sleipnir commented 1 year ago

Use import instead of use. Mix format

mmmries commented 1 year ago

❤️ 💛 💙 💚 💜 Thank you for the contribution. I've been meaning to add CI to make sure we keep this library working for multiple versions of elixir/otp. I'll try to branch from your changes and get that running

sleipnir commented 1 year ago

Hi @mmmries !

Cool, I took the liberty of including a simple pipeline that runs tests on different versions of OTP. If you find it unnecessary to do this PR, I can undo it

mmmries commented 1 year ago

Extra awesome! Thanks for providing the CI setup. I'll go ahead and merge and then maybe add a few elixir versions to the matrix in a follow-on PR to make sure that the move from use to import works well for elixir versions 1.10+

mmmries commented 1 year ago

Extra awesome! Thanks for providing the CI setup. I'll go ahead and merge and then maybe add a few elixir versions to the matrix in a follow-on PR to make sure that the move from use to import works well for elixir versions 1.10+

mmmries commented 1 year ago

Thanks again, for pushing this up. I added on testing a wider range of elixir versions and then published version 0.2.2 on hex with these changes in place.

sleipnir commented 1 year ago

Great! Thank you so much @mmmries