search

mmnaseri / cs-review

An effort to refresh my CS background
MIT License
251 stars 72 forks source link

LinearSelector improvement #9

Closed rfarhanian closed 6 years ago

rfarhanian commented 6 years ago

Linear Selector should divide the problem into subproblems around the pivot element. If the order is not the pivot element, it should not include the pivot index in the subproblem.

rfarhanian commented 6 years ago

No. I could not add a regression test due to the nature of the problem. There were no failing tests. I observed that the subproblem includes a part of the problem that is already solved so I tried to improve it. I also tried to add an edge case scenario. I will add my name to the author tag as you suggested.

mmnaseri commented 6 years ago

Sounds fair. The changes look good to me.