search

mmnaseri / proton.multi-list-picker

ProtonJS Multi List Picker component
MIT License
19 stars 5 forks source link

Presentation breaks inside an Ionic app #2

Open adyba opened 7 years ago

adyba commented 7 years ago

Hi Milad, I know it is advertised on a http://market.ionic.io but the demo itself is just a plain Angular and once I combined the democode with a plain ionic app it uses no Ion classes and be honest it looks kinda distorted. Is it just me? Have I done something wrong or it is the state of the project as-is? http://codepen.io/adyba/pen/woKeVW

babchai commented 7 years ago

facing the same issues.

mmnaseri commented 7 years ago

Interesting. I developed this for an app at my company and it was working fine with Ionic back then. I have not updated it since, but have gotten permission from my manager to release the code. I will see what is wrong with it. Most likely, there is a new SASS/CSS in Ionic that has conflicts with the styling of the component.

adyba commented 7 years ago

Nice. Looking forward to see any udates :+1:

jasonmamy commented 7 years ago

Have you had a chance to look at the SASS to see why it's distorted? Was looking forward to using this.

tverilytt commented 7 years ago

@jasonmamy @mmnaseri Agree, also looking forward to using this 👍

jasonmamy commented 7 years ago

I also found this thing that looked promising (all credit to the original author PeacePan):

ionic-picker-view

I made tweaks to input JSON for the labels/view, but it had a bunch of issues on a device where couldn't scroll to the last item, and some other annoyances (only tested on Android). I could check it into github if anyone is good with SASS to clean up the look+feel to make it usable or somehow integrate with this existing project.

Other ones I tried (but they didn't work as expected):

Couldn't get it to rotate 180 degrees:

morphing-carousel

On Android it doesn't look good (on iOS apparently looks great), if we could find a good open source 'wheel selector' I could integrate it into this project (I'm much more familiar with Java than JS/CSS/SASS), would give native functionality for the selector on both Android/iOS:

PhoneGap list picker

adyba commented 7 years ago

Thank you for digging @jasonmamy The @PeacePan piece looks great (after 5min playing with a forked Pen) I have tried to use the morphing-carousel last February. It looks good on desktop browser and some 10% Android devices but for the rest of the Android world and all iOS it just exploded. Maid be there was some overhaul since then I'm not aware of.

mmnaseri commented 7 years ago

Hey guys! So sorry for the late reply. I have been busy studying for a Google interview :)

Now that that's all past, I can probably sit down and fix this thing. I will start by creating a sample Ionic project containing a single page with this component and then try to see what's wrong with the SASS.

In the meantime, any help whatsoever is very appreciated since this is not my main focus and project at the moment.

mmnaseri commented 7 years ago

I haven't dug too deeply into this, but there are two issues that could be the root cause:

  1. Clash in naming with Ionic SASS classes
  2. Presumptions about defaults that are being overridden by Ionic

I will try to see which of these is the issue, and if possible, provide a quick fix.

jasonmamy commented 7 years ago

I've created a native number picker (Android as of now, will add in iOS) given the JS pickers seem to have issues, I can push to the npm registry if anybody is interested, still cleaning it up and fixing it a bit:

https://github.com/jasonmamy/cordova-wheel-selector-plugin

jcyh0120 commented 7 years ago

Thanks a lot @mmnaseri and @jasonmamy, these projects are amazing. I would like to try this in my ionic project. How long will it take for ios version @jasonmamy? I had no experience in ios and think it would take lots of time right?

jasonmamy commented 7 years ago

I'm not too familiar with iOS, but I'd guess a day or so if someone were familiar with it. I'll probably look at it in a couple weeks once I get around to getting a mac set up.

On Sun, Feb 5, 2017 at 6:05 AM, jcyh0120 notifications@github.com wrote:

Thanks a lot @mmnaseri https://github.com/mmnaseri and @jasonmamy https://github.com/jasonmamy, these projects are amazing. I would like to try this in my ionic project. How long will it take for ios version @jasonmamy https://github.com/jasonmamy? I had no experience in ios and think it would take lots of time right?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/mmnaseri/proton.multi-list-picker/issues/2#issuecomment-277521858, or mute the thread https://github.com/notifications/unsubscribe-auth/AJ9UxjWfZFqtuvWZ9h6kmw6Jtudv8W5Vks5rZdcfgaJpZM4Ktm2J .

jasonmamy commented 7 years ago

I added some minimal support for iOS (can at least use to select a single list item):

https://github.com/jasonmamy/cordova-wheel-selector-plugin

still have to figure out how to 'loop' over lists and dynamically create multiple wheel selectors in iOS.

On Sun, Feb 5, 2017 at 10:01 PM, JasonAmy jasonmamy@gmail.com wrote:

I'm not too familiar with iOS, but I'd guess a day or so if someone were familiar with it. I'll probably look at it in a couple weeks once I get around to getting a mac set up.

On Sun, Feb 5, 2017 at 6:05 AM, jcyh0120 notifications@github.com wrote:

Thanks a lot @mmnaseri https://github.com/mmnaseri and @jasonmamy https://github.com/jasonmamy, these projects are amazing. I would like to try this in my ionic project. How long will it take for ios version @jasonmamy https://github.com/jasonmamy? I had no experience in ios and think it would take lots of time right?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/mmnaseri/proton.multi-list-picker/issues/2#issuecomment-277521858, or mute the thread https://github.com/notifications/unsubscribe-auth/AJ9UxjWfZFqtuvWZ9h6kmw6Jtudv8W5Vks5rZdcfgaJpZM4Ktm2J .

mmnaseri commented 6 years ago

@adyba @babchai @jcyh0120 @jasonmamy More than a year after the issue was originally opened, I have come to say that I don't seem to have the time to maintain this project (you probably had guessed it all by now). I am ready to give ownership of this project to someone else. If anyone is interested, just give me shout out, and I might even be able to give you a rundown of the code (as much of it as I remember). In the meanwhile, as I have mentioned in the README, I think @jasonmamy's project seems to be promising and looks like has many of the same capabilities as this one, PLUS, it is being actively maintained.