search

mmnaseri / spring-data-mock

Mock facility for Spring Data repositories
MIT License
137 stars 44 forks source link

Spring Boot 2.0+ support #165

Closed binakot closed 4 years ago

binakot commented 4 years ago

Init implementation for Spring Boot 2.0+ support. It's not backward compatible with Spring Boot 1.0+ obviously. https://github.com/mmnaseri/spring-data-mock/issues/163

The main differences: 0) Switch to Java 8, update all dependencies to the last versions. 1) CrudRepository and Auditable return Optional of value instead of value itself. 2) The key in CrudRepository doesn't implement Serializable interface anymore. 3) There are a lot of changes from constructor creating with new keyword to static builder methods. 4) DateTime from JodaTime was changed to Instant from DateTime API. JodaTime was removed from dependencies at all.

mmnaseri commented 4 years ago

@binakot Thanks a lot for taking care of this. I know it took me a couple of days to go through it all, but I finally did it. If you can make the couple of tiny, nit-picking changes I have requested, I'll merge. Otherwise, if you think you don't have the time for those, I can merge and do it myself.

Also, I think these are breaking changes, that need to start a new major version to reflect the change from Spring Data 1.x to 2.x. What do you think?

binakot commented 4 years ago

@mmnaseri Great! I'll do changes myself, no problems :) Yes, it's not backward compatible and will work with spring boot 2+ only. New major is true way. And I think you should update readme after new release to let to know developers about it :octocat: