mmod / mmod-panel

MMOD Panel is an upgrade to the Topbar in Gnome3, creating a customizable panel and providing options for fine-tuning your Desktop Experience.
Other
12 stars 8 forks source link

Support Gnome 3.14 #13

Closed steelbrain closed 9 years ago

steelbrain commented 9 years ago

Just like the title says

kirvedx commented 9 years ago

Unfortunately, that's hardly descriptive enough; MMOD-Panel was written on and for 3.14.

In order to provide you proper support, it'd be helpful to know the following:

steelbrain commented 9 years ago

I tried using it on Ubuntu 14.10 GNOME Shell 3.14 (installed from the dev PPAs), When I click the enable button nothing happens, and I do see it in my installed extensions list in gnome-tweak-tool, but with an warning sign, and the enable button disabled.

Edit: Any ideas how can I capture some debug info?

kirvedx commented 9 years ago

Any ideas how can I capture some debug info?

Open GUI Syslog and scroll to the bottom of the log for system, then restart your shell via alt+f2, enter r, and hit enter. New messages that include Gjs and mmod-panel are the relevant messages.

Also using alt+f2, enter lg, and hit enter will open Gnome Looking Glass. Hit the Extensions tab and scroll to MMOD Panel, and then click Show errors (typically next to where it says either Enabled or Disabled).

Also, other extensions that modify the top bar will interfere; u should remove them if u want MMOD-Panel.

Examples of such extensions:

steelbrain commented 9 years ago

Found it

TypeError: main.panel.statusArea.aggregateMenu.menu._getMenuItems(...)[9].addMenuItem is not a function
kirvedx commented 9 years ago

On Tue, 2015-03-24 at 16:30 -0700, Steel Brain wrote:

Found it

TypeError: main.panel.statusArea.aggregateMenu.menu._getMenuItems(...)[9].addMenuItem is not a function — Reply to this email directly or view it on GitHub.

That's a bug with Ubuntu, though it should be fixed with the latest update. If you are comfortable modifying a file, I can give you instruction for getting it working now - and I'll update the code again with the proper case argument (I probably checked against an array index existing, instead of whether or not the function member existed).

Rik

steelbrain commented 9 years ago

If it'll make the extension work, then sure, why not.

kirvedx commented 9 years ago

in ~/.local/share/gnome-shell/extensions/mmod-panel@mmogp.com/lib/mmod/aggregate.js, specifically line 88, You will see the following:

if( main.panel.statusArea.aggregateMenu.menu._getMenuItems()[9] )

It needs to be changed to:

if( main.panel.statusArea.aggregateMenu.menu._getMenuItems()[9] && typeof main.panel.statusArea.aggregateMenu.menu._getMenuItems()[9].addMenuItem === 'function' )

Then use the previous instruction to restart the shell. Afterwards if MMOD-Panel doesn't start automatically, you should be able to enable it.

Please let me know how that works for you.

steelbrain commented 9 years ago

I just rebooted my computer and the extension was working again with no modification at all. Weird, but works.