search

mmohades / Venmo

Venmo API client for Python
GNU General Public License v3.0
145 stars 43 forks source link

New Transaction type #10

Closed Msender98 closed 4 years ago

Msender98 commented 4 years ago

I've been using your code to pull venmo transactions (really helpful! thank you!) and ran into a transaction type semi often that wasn't handled. Just added it to the TransactionType class.

The other change I ran into while running pip install locally on my forked code. I had to add the explicit utf-8 encoding.

mmohades commented 4 years ago

Thanks for opening a PR. What is a disbursement transaction, and how can I make one?

Msender98 commented 4 years ago

I had it come up in error messages a few times. An example, trying: venmo.user.get_user_transactions(user_id = '1539091850067968476')

Gives: ValueError: 'disbursement' is not a valid TransactionType

On Sun, Aug 9, 2020 at 6:16 PM Mark Mohades notifications@github.com wrote:

Thanks for opening a PR. What is a disbursement transaction?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/mmohades/Venmo/pull/10#issuecomment-671107380, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADTOFCOC7AWJVFTQLHFXM6DR74N3LANCNFSM4PKTOMEA .