search

mmohades / Venmo

Venmo API client for Python
GNU General Public License v3.0
145 stars 43 forks source link

Return device-id after login #36

Closed alexwilson1 closed 3 years ago

alexwilson1 commented 3 years ago

This pull will allow the user to programmatically save the generated device-id for future reference.

mmohades commented 3 years ago

This PR includes other changes other than device-id, so I'm gonna close it. You can do it in the same PR that's currently open. For device-id, changing non-private methods's signature will cause a lot of other developer's code to break. I'd say make add a get_device_id() method to Client, and store the device_id as a private variable in the Client once get_access_token is called. get_device_id() should return the latest device-id used for logging in or None if no login has happened.