search

mmohades / Venmo

Venmo API client for Python
GNU General Public License v3.0
145 stars 43 forks source link

Add Merchant Transaction Support #53

Closed babbitt closed 2 years ago

babbitt commented 3 years ago

The following adds support for transactions that occur between a user and a merchant (such as a restaurant). These are common when using a Venmo credit or debit card.

These changes introduce no breaking changes from what I can tell.

First time contributor to the package so I opted for style consistency over readability in certain cases. Please feel free to offer other solutions. No offense taken in advance.

If these are welcome I'd also be interested in adding bank transfer transaction support.

mmohades commented 3 years ago

Also, please install pylint to help with some of the style suggestions. https://code.visualstudio.com/docs/python/linting

babbitt commented 3 years ago

Happy to make these changes! Definitely just left this PR in kind of a garbage state as a POC to make sure it would even be of interest. I'll get started on those changes you suggested and see if I can cook up anything else of my own.

mmohades commented 3 years ago

Any updates on this?

babbitt commented 3 years ago

Apologies. Just got back to college so this (as most things) is a bit in flux. You'll see an update from me sometime in the next week or so just getting settled back in here.

mmohades commented 2 years ago

Closing due to inactivity. Please feel free to open a new PR.