search

mmomtchev / node-gdal-async

Node.js bindings for GDAL (Geospatial Data Abstraction Library) with full async support
https://mmomtchev.github.io/node-gdal-async/
Apache License 2.0
133 stars 26 forks source link

Feature: coordinate transform with proj error code #32

Closed khrushjing closed 2 years ago

khrushjing commented 2 years ago

When I tried the coordinate transform, the error message reported was very sketchy. Finally I found out that the latitude and longitude were filled in backwards. So I filled in the api.

mmomtchev commented 2 years ago

Why are you creating a new method? I am inclined to merge this into the existing method?

codecov-commenter commented 2 years ago

Codecov Report

Merging #32 (bec3d8e) into master (6546b0c) will increase coverage by 0.02%. The diff coverage is 36.00%.

@@            Coverage Diff             @@
##           master      #32      +/-   ##
==========================================
+ Coverage   90.45%   90.47%   +0.02%     
==========================================
  Files          95       95              
  Lines       10818    10804      -14     
==========================================
- Hits         9785     9775      -10     
+ Misses       1033     1029       -4
Impacted Files Coverage Δ
src/gdal_coordinate_transformation.hpp 50.00% <ø> (+2.00%) :arrow_up:
src/gdal_coordinate_transformation.cpp 65.51% <36.00%> (-3.38%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6546b0c...bec3d8e. Read the comment docs.

khrushjing commented 2 years ago

I'm a newbie programmer, because in gdal, both api exist. Perhaps, seeing that you are interested in this pr, I would be happy to merge the two api's.

khrushjing commented 2 years ago

I merged the two api's. Now the error message can see the proj error code.