mmomtchev / node-gdal-async

Node.js bindings for GDAL (Geospatial Data Abstraction Library) with full async support
https://mmomtchev.github.io/node-gdal-async/
Apache License 2.0
129 stars 26 forks source link

default to `GDT_Unknown` on vector datasets #88

Closed mmomtchev closed 1 year ago

mmomtchev commented 1 year ago

fix #84 and add unit testing for the OpenFileGDB driver

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage has no change and project coverage change: +0.04 :tada:

Comparison is base (d0f7b01) 90.71% compared to head (36c6f7d) 90.76%.

:exclamation: Current head 36c6f7d differs from pull request most recent head f65e1f9. Consider uploading reports for the commit f65e1f9 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #88 +/- ## ========================================== + Coverage 90.71% 90.76% +0.04% ========================================== Files 95 95 Lines 10711 10712 +1 ========================================== + Hits 9717 9723 +6 + Misses 994 989 -5 ``` | [Impacted Files](https://app.codecov.io/gh/mmomtchev/node-gdal-async/pull/88?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Ing.+Rockatansky) | Coverage Δ | | |---|---|---| | [src/gdal\_driver.cpp](https://app.codecov.io/gh/mmomtchev/node-gdal-async/pull/88?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Ing.+Rockatansky#diff-c3JjL2dkYWxfZHJpdmVyLmNwcA==) | `84.44% <ø> (-1.38%)` | :arrow_down: | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/mmomtchev/node-gdal-async/pull/88/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Ing.+Rockatansky)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.