search

mmone / OctoprintKlipperPlugin

A plugin for a better integration of Klipper into OctoPrint.
GNU General Public License v3.0
83 stars 62 forks source link

Feature request: Display current offset in the set offset window #14

Open arminth opened 6 years ago

arminth commented 6 years ago

Hi Martin, I am so happy with your plugin! Especially with the set offset function, as it saves me a ton of failed prints! Still, it would be nice to see the actual value of the existing offset. This could then be used as an input to optimize the sensor-offset and virtual Z-endstopposition in the firmware-configuration. At the moment, the offset is gone after a reboot (not sure even after a disconnect or firmware restart).

No hurry - away from my printer for more than 4 weeks starting tomorrow (work, not holidays). :(

Keep up the good work and schönen Sonntag!

Cheers Armin

mmone commented 6 years ago

To display the current offset in the dialog is possible as it is returned by GET_POSITION. But I won't restore any state of the Klipper process after "RESTART", "FIRMWARE_RESTART". That would lead down a rabbit hole. This is something that needs to be done on the Klipper side of things. There is an ongoing discussion on how to make runtime settings like this persistent eg. in this PR: "bed_mesh: Mesh Bed Leveling for Klipper"