CRLF in printer.cfg if editing in octoklipper

mmone / OctoprintKlipperPlugin

A plugin for a better integration of Klipper into OctoPrint.

GNU General Public License v3.0

83 stars 62 forks source link

CRLF in printer.cfg if editing in octoklipper #34

Closed faboaic closed 5 years ago

faboaic commented 5 years ago

OctoPrint version : 1.3.10 OctoPi version : 0.14.0

Editing printer.cfg in octoklipper makes it useless by adding "windows newline" to the file.

File contains parsing errors: [line 127]: 'G90\n' [line 128]: 'G1 Z15 F300\n' [line 129]: 'G28 X0 Y0\n' [line 130]: 'G1 X30 Y30 F1200\n' [line 131]: 'G4 P500\n' [line 132]: 'G28 Z0\n' Once the underlying issue is corrected, use the "RESTART" command to reload the config and restart the host software. Printer is halted Klipper state: Not ready

faboaic commented 5 years ago

Until now I only used octoklipper edit config function for editing values inside a line. But if you add lines it seems to add '\n' which leads to that problem.

Browser used for octoprint was chrome on windows 10 x64.

faboaic commented 5 years ago

Seems to have been a syntax error... After 'gcode:' command the gcode lines must have some space before them.