search

mmone / OctoprintKlipperPlugin

A plugin for a better integration of Klipper into OctoPrint.
GNU General Public License v3.0
84 stars 61 forks source link

Fixes for Issues #19, #23, #31, #32 and #33 #36

Open jameseleach opened 5 years ago

jameseleach commented 5 years ago

Send the three GCode commands with one OctoPrintClient.control.sendGcode command by sending an array of strings instead of three separate commands with individual strings.

This ensures that the three move commands are always processed in order.

jameseleach commented 5 years ago

This same technique (sending multiple Gcode commands as an array of strings instead of a single string) is also a potential resolution to #19 and #32.

I'm unable to test the changes to klipper_param_macro.js at the moment but will do so when I can - or if someone else can test and leave feedback that'd be appreciated.

DMCShep commented 4 years ago

Is there any chance of seeing this merged? This is a rather big ticket item, we get people on the Klipper Discord having their config files wiped out and they aren't even aware this is a known issue nor that there is an active fix for it.

baodrate commented 4 years ago

Is there anyone already maintaining a fork, since this repo seems abandoned (no hate, just sayin)? If no one's up for it I'll give it a shot, but I'm not that familiar with Octoprint's code.

jameseleach commented 4 years ago

"Maintaining a fork" is a bit strong of a term.. But I do have the fork I did to fix these bugs. I've not been doing any 3d printing for a while and have just installed a Pi with OctoPrint and noticed that the OctoprintKlipperPlugin is no long listed... Not sure what the best option is to remedy this situation!

JohnEdwa commented 4 years ago

@jameseleach If you, or someone else, wants to take over maintaining the plugin the process is dead simple - just post an issue asking if the plugin is abandoned or not (which it clearly is) and after two weeks, you can open an issue at https://github.com/OctoPrint/plugins.octoprint.org/issues and ask for the plugin to be transferred to you.