mmone / OctoprintKlipperPlugin

A plugin for a better integration of Klipper into OctoPrint.
GNU General Public License v3.0
84 stars 61 forks source link

[Feature Request] Python 3 Compatibility #66

Open definitely-not-a-t-rex opened 3 years ago

definitely-not-a-t-rex commented 3 years ago

Please add Python 3 Compatibility as outlined here.

cowboy3d commented 3 years ago

Just tried to make it work with Python 3 - looks good so far but will need testing.... Dialogs show up, need to check if communication with printer works too.

damccull commented 3 years ago

I would like to add my voice to this request. Let's get modernized. At the moment, this is the only plugin I use holding me back on 2.7.

cowboy3d commented 3 years ago

...I have a working version here: https://github.com/cowboy3d/OctoprintKlipper3Plugin.git For me it works now for a lot of prints for nearly two weeks - but maybe other people are using it differently then myself. I did rename the plugin to avoid confusion / mixups with the original one... if the author decides to update his work, this would be to way to go. Feel free to try my version and let me know if it works for you, too.

Twilek-de commented 3 years ago

@cowboy3d Seems to work fine here. Thanks a lot!

luco85 commented 3 years ago

Hi! For me not work. Klipper tab is ok but Plugin settings are blank, and connection tab (at sx) is missing and i have a new tab Called octoklipper3!?😭😭

Twilek-de commented 3 years ago

@cowboy3d Octoprint gave me the option to update Octoklipper3 to a new version (0.0.2) automatically, which totally wrecked it. I than had the same problems as @luco85. Reverting back to your original version and ignoring the update notice made things work again.

luco85 commented 3 years ago

@Twilek-de have you link of first version? Thanks

cowboy3d commented 3 years ago

Sorry - seems I made a stupid mistake. Just corrected it and version 0.0.3 is working, at least for me. Besides there seems to be good ones: the original plugin will get a new maintainer soon.... https://github.com/OctoPrint/plugins.octoprint.org/issues/599

Please let me know if you still experience problems.

Twilek-de commented 3 years ago

Thanks a lot. I have just started a 34 hour, print so I cannot test it just yet, but I am sure it will work, I will report as soon as I can test it.

luco85 commented 3 years ago

Wow! Now it work! Thanks!!

Twilek-de commented 3 years ago

Print failed, Octoklipper works :-)