mmontag / chip-player-js

Web-based music player for a variety of video game and chiptune music formats.
https://chiptune.app
GNU General Public License v3.0
324 stars 17 forks source link

Silence detection skips song when channels are muted #131

Closed applecuckoo closed 1 year ago

applecuckoo commented 1 year ago

Hi there, if you play Green Hill Zone from the Genesis section and solo FM 1, it skips to the next song after 10 seconds. I believe this is a silence-related timeout, since I tried soloing FM 2 and it doesn't time out.

mmontag commented 1 year ago

Yes, indeed you are correct. game-music-emu library uses silence detection to decide when the track ends. And this is really annoying when muting channels.

I think some tracks do rely on this silence detection, like sound effects or short jingles (will verify). In that case, one fix would be to disable silence detection whenever track muting is applied. It might introduce other problems, but still better than current behavior.

mmontag commented 1 year ago

Merged a fix - let me know if you still have this problem.

mmontag commented 1 year ago

Dupe of #15