search

mmontag / chip-player-js

Web-based music player for a variety of video game and chiptune music formats.
https://chiptune.app
GNU General Public License v3.0
324 stars 17 forks source link

Parent directory navigation is broken #146

Closed mmontag closed 1 week ago

mmontag commented 4 months ago

Parent directory links CleanShot 2024-02-21 at 16 31 22 are now using history.back() in a cheap ploy to get scroll position restoration, but of course this only works when the previous location is the parent directory.

It makes sense to keep the history.back() behavior when the previous location is the parent directory (subjectively, I think unwinding the history is desired behavior here). But this should be a special case, and .. should be a normal hyperlink behavior when previous location does not match the parent directory.

mmontag commented 1 week ago

Can't reproduce, I need to write better repro instructions. Closing