NSF ends too early - Githubissues

mmontag / chip-player-js

Web-based music player for a variety of video game and chiptune music formats.

https://chiptune.app

GNU General Public License v3.0

345 stars 19 forks source link

Closed mmontag closed 10 months ago

mmontag commented 5 years ago

The NSF format doesn't have any built-in notion of song duration.
game-music-emu determines the end of an NSF song when 2 seconds of silence is detected.
Some NSF repeat forever, so you need a max-length in addition to silence detection.
NSF format is fixed at max-length 2:30 in game-music-emu.
If you set the max length to something like 99:00, you will end up listening to the repeating songs for a long time.

mmontag commented 10 months ago

The solution to this is to use NSFE files, which have been added for the vast majority of NES and Famicompo music.