Open mmontag opened 4 years ago
Note from zaphod77 via Reddit:
Some files contain both "basic midi" and "extended midi" this was an old win 3.0 standard. all such mid files have a special marker in them. canyon.mid, ballade.mid, jazz.mid, and reggae.mid are all examples of this. "It turned out all of the files contain a totally undocumented Sequencer specific meta event (0x7f) with a 3 byte data value of '00 00 41'." The player should look for the marker, and if that marker is found, auto mute tracks 11-16.
All of Lands of Lore 1 also give the same type of Invalid MidiFileTrack (0xe) : No track end event found at the expected index ([index]).
error that Theme Hospital above does: https://chiptune.app/browse/Game%20MIDI/Lands%20of%20Lore%20(PC%E2%88%95DOS,%201993)
Shining Force II - Ending causes crash; the one in the /original folder does not. https://gifx.co/music/Sega%20Genesis/Shining%20Force%20II/31%20-%20Ending.vgz
No crash: https://chiptune.app/?play=Sega%20Genesis%2FShining%20Force%20II%2Foriginal%2F31%20-%20Ending.vgz
List of troublesome files
MIDI
Yu-No pyn_007b.mid ERROR: Invalid MIDIFileTrack (0x3e0) : The track size exceed the buffer length.
EVE Burst Error EVE_07.MID ERROR: 0x4b Running status without previous event Due to shift-JIS encoded track titles
~Gran Turismo MIDI files spu_04.mid, Smokey Robinson - I Second That Emotion.mid , Taito - metalb2.mid , Aqua - Barbie Girl.mid ~ ~Drum channel is playing as piano (probably due to a bad bank select event combined with this change https://github.com/mmontag/chip-player-js/commit/7bb5db2390d14122d4b2d0c02819394f23aef5d8 - which reverts hardcoded ch10 bank selection in fluidlite.) Fix it in the MIDI player (ignore drum channel bank selects)?~
Even More Incredible Machine, The - 06. Rock.MID - stuck note at end of track; song hangs. This game also has an extra drum channel that plays as piano
Tyrian MIDI files Camanise.MID MThd prefix not found. Bad game rip? Doesn't work with MIDIPlayer X
Transport Tycoon Deluxe Invalid MIDIFileHeader : MThd prefix not found
LB3_-_Felest_Tower.mid - Sounds jittery with external MIDI device. Could be issue with the custom MIDI throttling code in MIDIFilePlayer.js, or due to excessive CC 10 (panning) on channel 1, 2, 3, 4.
https://chiptune.app/?play=Contemporary%2FSTAFFcirc%20vol.%209%20-%20MIDI%20MODULE%20FANATIX%2F16%20HueArme%20-%20Yakumotatsu%20(Microsoft%20GS).mid almost 1 MB, like black MIDI, meant for Microsoft GS softsynth and breaks throttling
Theme Hospital
Error: Unable to play Game MIDI/Theme Hospital (PC∕DOS, 1997)/Steady.mid (Invalid MIDIFileTrack (0xe) : No track end event found at the expected index
https://chiptune.app/?play=MIDI%2FCamel%2FThe%20Snow%20Goose.1.mid 4357 minutes long
MDX
VGM
~On certain VGZ files there's volume inconsistency. One of the prime examples is in Black Knight 2000 main theme. Notice how the vocals, as well as percussion are very quiet compared to the rest of available voices. Here's the video of the main theme BGM of this pinball machine. Notice how the percussion can be heard, as well as all the vocals. https://www.youtube.com/watch?v=p61YjWczwLM&t=17s~ This was fixed when vgm playback was switched to libvgm.
MOD