mmontag / chip-player-js

Web-based music player for a variety of video game and chiptune music formats.
https://chiptune.app
GNU General Public License v3.0
332 stars 18 forks source link

Looping commands in modules cause playback bar to jump around #54

Closed mankeli closed 1 year ago

mankeli commented 3 years ago

For example at 05:00 in this mod.

mmontag commented 1 year ago

I think this is a quirk of libxmp (underlying library).

It does not report a monotonically increasing playback position, but exposes only the raw xmp_frame_info.time https://github.com/libxmp/libxmp/blob/master/include/xmp.h#L326. Similarly, I don't think the reported duration takes loops into account. It is only an estimate. Would prefer not to patch libxmp, so this is how it will remain for now.

https://github.com/libxmp/libxmp/blob/f56472b117c592e3056a8d89aae847496df7dfac/docs/tracker_notes.txt#L218