search

mmontag / chip-player-js

Web-based music player for a variety of video game and chiptune music formats.
https://chiptune.app
GNU General Public License v3.0
332 stars 18 forks source link

Fluidsynth MIDI playback is glitchy #67

Closed mmontag closed 3 years ago

mmontag commented 3 years ago

I have no idea how this regression was introduced, but my MIDI playback with the SoundFont engine is now glitchy and stuttery.

Doesn't seem correlated to CPU usage. Flame graph looks normal, unless the missing towers are causing the glitches.

image

soltune commented 3 years ago

I too have noticed that this issue has began after updating my browsers recently. (for the last two months or so?). This seems to be noticeable in the players with higher loads, like .spc format.

Is this issue related to that ScriptProcessorNode is deprecated? Unfortunately I have no idea...

mmontag commented 3 years ago

Yeah, I suspect there was some kind of performance hit (deliberate or not) in Chrome web audio.

I’ve been using Safari for a few days with none of the same issues.

On Fri, Apr 2, 2021 at 7:54 PM soltune @.***> wrote:

I too have noticed that this issue has began after updating my browsers recently. (for the last two months or so?). This seems to be noticeable in the players with higher loads, like .spc format.

Is this issue related to that ScriptProcessorNode is deprecated? Unfortunately I have no idea...

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/mmontag/chip-player-js/issues/67#issuecomment-812799692, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAHG7RPPJMYAGZK4HXG4MCDTGZ7NNANCNFSM42DRU6IA .

-- Sent from Gmail Mobile

soltune commented 3 years ago

@mmontag I just pushed a pull request(#68) to fix this issue. Could you check it out?

mmontag commented 3 years ago

Thanks for the PR! Playback is fixed on my end, closing the issue.