search

mmontone / cl-forms

Web forms handling library for Common lisp
http://mmontone.github.io/cl-forms
MIT License
43 stars 5 forks source link

Failed to build for Quicklisp dist #3

Closed quicklisp closed 4 years ago

quicklisp commented 4 years ago

Building with SBCL 2.0.9.5-442f54894 / ASDF 3.3.1 for quicklisp dist creation.

Commit id f2e4b7ec6e7c7dd9e20059c75e8fcbd1558775ac

cl-forms.peppol fails to build with the following error:

Unhandled ASDF/FIND-COMPONENT:MISSING-DEPENDENCY in thread #<SB-THREAD:THREAD "main thread" RUNNING {1001A50103}>: Component #:PEPPOL not found, required by #<SYSTEM "cl-forms.peppol">

Full log here

quicklisp commented 4 years ago

Getting this now: 

; caught ERROR:
;   READ error during COMPILE-FILE: Symbol "ISO 4217 Currency codes" not found in the PEPPOL/CODE-LISTS package. Line: 75, Column: 63, File-Position: 2666 Stream: #<SB-INT:FORM-TRACKING-STREAM for "file /home/quicklisp/quicklisp-controller/dist/build-cache/cl-forms/9d24559d3984b60d0b534a34d354939dc2d855a2/cl-forms-20201009-git/src/peppol.lisp" {10094185D3}>
mmontone commented 4 years ago

Oh. Mm. Sorry. Will check.

mmontone commented 4 years ago

It's odd it compiles fine locally. Checking ...

mmontone commented 4 years ago

It must be the fasl cache.

mmontone commented 4 years ago

I don't have that error, compiles fine.

But changed things so that I'm accessing the symbol with '::', not assuming it is exported, although it should.

Compiles now? Can you try again?

quicklisp commented 4 years ago

Still failed for me. Here's how I reproduced the warning locally:

At the tail end I see the warnings. Do you?

Could it be related to how you load those extra files?

mmontone commented 4 years ago

No. I'm not being able to make it fail, and no warnings show up for me :)

Yes, it must be the way I'm loading the code lists.

:perform (asdf:compile-op
            :after (o c)
            (dolist (code-list-file (uiop:directory-files (asdf:system-relative-pathname :peppol "code-lists/*.lisp")))
              (load code-list-file))))

I think I'm just going to hard code them in the asdf.

mmontone commented 4 years ago

Although I see I'm calling load there, instead of compile-file.

mmontone commented 4 years ago

I've hardcoded the code lists in the ASDF definition. Can you try again after pulling from cl-peppol?

quicklisp commented 4 years ago

All is good now, thanks!