search

mmontone / emacs-inspector

Inspection tool for Emacs Lisp objects.
GNU General Public License v3.0
108 stars 9 forks source link

add treeview to package-requires of inspector.el #10

Closed mjoerg closed 1 year ago

mjoerg commented 1 year ago

This is necessary so that treeview is also included as a requirement in the generated inspector-pkg.el file.

mmontone commented 1 year ago

I don't like this change because tree-view is a dependency of tree-inspector module, not inspector module. So, this is is more of a ELPA limitation. Perhaps I should be more flexible and do this ...

mjoerg commented 1 year ago

The problem right now is, that installing the package from ELPA results in an error because treeview is not installed automatically since it is not recognized as a dependency.

However, there are two other solutions than the one I proposed:

mmontone commented 1 year ago

Those two options sound fine to me. Perhaps cleaner would be option 2, create a separate git repo. But I'd also accept option 1 if you want to make a pull request for it.

El dom., 8 ene. 2023 17:24, mjoerg @.***> escribió:

The problem right now is, that installing the package from ELPA results in an error because treeview is not installed automatically since it is not recognized as a dependency.

However, there are two other solutions than the one I proposed:

  • Manually include inspector-pkg.el with the correct dependencies in the repository.
  • Move tree-inspector into a separate package, with inspector as a dependency.

— Reply to this email directly, view it on GitHub https://github.com/mmontone/emacs-inspector/pull/10#issuecomment-1374919865, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADKPDTK2R5Z7L4LDOEQLUTWRMO7DANCNFSM6AAAAAATUXDTLQ . You are receiving this because you commented.Message ID: @.***>

mjoerg commented 1 year ago

I would also prefer the cleaner option with separate packages.