mmontone / emacs-inspector

Inspection tool for Emacs Lisp objects.
GNU General Public License v3.0
107 stars 9 forks source link

[fix]: default value of inspector-pp-max-width and inspector-pp-use-m… #15

Closed nhannht closed 1 year ago

nhannht commented 1 year ago

Another issue I think you should change. Cannot insert directly with tree-inspector package from elpa. You should inform normal user config their package management load tree-inspector.el Example with Doom emacs package manager

(package! tree-inspector
  :recipe (:host github :repo "mmontone/emacs-inspector/"
                 :files ("tree-inspector.el")))

Finally for some reason my Emacs not auto-install treeview package even require 'treeview in the source code, maybe should add this line in use-package

(use-package tree-inspector
  :after '(treeview) )
mmontone commented 1 year ago

Hello. Thanks for the PR. Didn't know about the pp package not being loaded.

As an alternative, how about checking with featurep? : (if (featurep 'pp) pp-max-width "window-width")). ?

mmontone commented 1 year ago

I don't use use-package and use-package!, I just install from package-list-packages. That's why I haven't included more docs with that.

nhannht commented 1 year ago

Sorry, this is the first time I pr to other Emacs-related package and Doom-related package, I need to recheck some technical details. I will close this PR and replace it with better later.

mmontone commented 1 year ago

Your code is not bad. In fact, that code you touched is new and is very possible that is not working well for all Emacs distros. I've been lazy an only tested for v29.1. I'll apply some changes. Don't hesitate to open another one, you could open another one clarifying the docs README perhaps.