search

mmoreram / SpotifyApiBundle

Spotify Api Bundle for Symfony2
MIT License
12 stars 1 forks source link

Extract business code into spotify-api library #9

Open mickaelandrieu opened 10 years ago

mickaelandrieu commented 10 years ago

As a very quick review, you don't realy need Sensio/Buzz-Bundle but only buzz (or guzzle, at this point ?).

When the library has been done, this will be very easy to add the glue into a bundle.

What do you think ?

mmoreram commented 10 years ago

@mickaelandrieu wow, you're right! Dependency is with Buzz.

Can you change that please?

Thanks for that review :+1:

mickaelandrieu commented 10 years ago

aww I don't have time for this :(

Maybe on saturday ? I (may) need this library too :)

mmoreram commented 10 years ago

I'll do this afternoon.

Thanks.

mickaelandrieu commented 10 years ago

wait, take a look to hi s: https://github.com/jwilsson/spotify-web-api-php

Do we realy need to make your own PHP library ? :)

mmoreram commented 10 years ago

I did this bundle 2 years ago... what can I say? actually +2000 downloads.

Good enough.

mickaelandrieu commented 10 years ago

Sure ^_^

As you like to make your own library or not, we can also "Bundle" the @jwilsson's library into bundle in the 2.x release.

jwilsson commented 10 years ago

I don't know how you want to do things but if you decide to bundle my library, let me know if you need any help!

mmoreram commented 10 years ago

@jwilsson Thanks :)