Closed hacfi closed 9 years ago
ping @mmoreram
@hacfi I've been so busy :( After the Con I will review both PRs and I'll merge them. Thanks for your effort :)
ping @hacfi I need this feature to be tested properly, and to be ensured that:
Thanks
@mmoreram Sorry..overlooked that there are already tests. Will work on them next week.
Had a little rebase conflict because of my other PR but all fixed now.
Included a small test for both this PR and #12. Wasn’t sure how to test for no bc breaks but all previous tests passed!?
@mmoreram anything missing?
ping @mmoreram :grin:
RTM @mmoreram :grinning:
@hacfi Could you please document this feature? Ready to be merged...
@mmoreram Sure. Just noticed that this feature can’t be used without the config or is there a way to pass an array as a cli argument?
Fixed some typos while I was at it
Just found I can't join _main
with another namespaces inside same group, like:
use-sort:
group:
- [ Symfony, _main ]
- Elcodi
@xphere Will have a look on the weekend..I only had sub-namespaces in mind so didn’t check that.
Hmmm ok :) Please, fix asap as possible :')
I don’t really understand the use-case but will try to fix it asap.
well, let's find out what the problem is, let's add some tests in order to make them fail, and then, let's fix it :dancer:
ASk me some help if you need it ! :)
Example .formatter.yml:
to put Symfony\Component\HttpKernel classes on top of the group
Fixes #10