search

mmorise / World

A high-quality speech analysis, manipulation and synthesis system
http://www.kisc.meiji.ac.jp/~mmorise/world/english
Other
1.18k stars 255 forks source link

Fixed const correctness Synthesis() #22

Closed wuaalb closed 7 years ago

wuaalb commented 7 years ago

Was mutable array of mutable arrays, as constant pointer; now constant array of constant arrays, as mutable pointer.

mmorise commented 7 years ago

Thank you for your good comments. Your comment is exactly right But, your request does not follow a rule that each line of text should be at most 80 characters long.

Since there were same points in other files, I modify all files if I may. On the other hand, I'd like to merge the other request in harvest.h to clearly record your effort. If possible, could you withdraw the first request and remain the second request? Or could you modify the first request to follow the rule?

wuaalb commented 7 years ago

I think the line length should be <= 80 now.

I changed these small things because I wanted to improve the Python wrapper a little. If you prefer to make these changes yourself and close this PR that's fine too (or add commit to this PR).

Thanks.

mmorise commented 7 years ago

Thank you for your effort. I accept your pull request. And I will revise the same issue in other files.